Hello, We're elaborating our Linaro Gerrit (2.2.1) set up, and would like to enforce separation between upstream and "our" branches, to disallow stray commits to upstream branches and keep them pullable from AOSP. So, we'd like to limit review requests, pushes, etc. to "refs/heads/for/linaro*" and "refs/heads/linaro*".
Trying to enter exactly that into refs entries for All Project's ACL lead to "Invalid Name" error. After looking at Gerrit's source, it turns out that Gerrit expects *-using pattern to end with "/*". Well, why? Yes, it's nice idea to use hierarchical-like branch names. Sometimes. But there're also good reasons to restrict branch name to generic "identifier". For example, to keep one-to-one mapping with filenames (confined to some dirs), or database names (both useful for CI for example). So, requiring slash present before "*" seems like arbitrary restrictions. Anyway, I wasn't too upset, knowing that arbitrary patterns can be encoded using regexps, and that's where real surprises start. First of all, looking at example regexps at http://gerrit.googlecode.com/svn/documentation/2.2.1/access-control.html#_project_access_control_lists there were suspiciously stray backslashes in pattern examples. Anyway, I tried to input "^refs/heads/linaro.*", it was rejected with "Invalid Name" error. Same for "^refs/heads/linaro.*". Then I just tried example from the doc, both as is and with slashes stripped - "\^refs/heads/[a-z]\{1,8\}" & "^refs/heads/[a-z]{1,8}". Same error. Looking at the source, validation for regexp case is complicated (and nothing points to backslashes being required): it seems to generate a subject string which would match entered pattern, and test that simple for being good refs syntax. Well, I thought, maybe UI validation outslies itself, and commit changes directly to project.config of refs/meta/config branch of All-Project. No avail. With config like: [access "^refs/for/refs/linaro.*"] push = group Registered Users it's not possible to submit review against any branch at all. Thinking here would be that may be regexp library is not available, or regexp syntax is not enabled by some option, but just searching reviews with queries like below works just ok: "project:^platform/buil. status:open" "project:^platform/buil.* status:open" "project:^platform/buil.+ status:open" So, I'm stumbled here - what could be wrong, and where to look next? Thanks, Paul Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
