On 06/13/2011 10:43 AM, Somebody in the thread at some point said:
Hi jserv -
Can you review Kan-Ru's patch? Since Android assumes full-functional
PM, it is vital to improve the resuming behavior of OMAP framebuffer.
You're right about needing working suspend / resume... the idea sounds
fine to my limited understanding of the since it's just setting again
the mode already in the fb info. I don't understand the locking
situation in console code but I guess the console can't wake until the
frame buffer has resumed.
There are just some style comments from me.
+static int omapfb_resume(struct device *dev)
+{
+ struct platform_device *pdev = to_platform_device(dev);
+ struct omapfb2_device *fbdev = platform_get_drvdata(pdev);
+ int i;
lose all the { }
+ if (fbdev != NULL) {
if (fbdev)
+ for (i = 0; i< fbdev->num_fbs; i++) {
+ omapfb_set_par(fbdev->fbs[i]);
+ }
+ }
Blank line here
+ return 0;
+}
-Andy
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
