On Mon, Mar 14, 2011 at 10:20:16AM -0500, Rob Herring wrote:
> Shawn,
>
Hi Rob,
> On 03/14/2011 09:25 AM, Shawn Guo wrote:
> >The pad configuration is something common between dt and non-dt
> >kernel, so it can be copied from non-dt code directly.
> >
> >Signed-off-by: Shawn Guo<shawn....@linaro.org>
> >---
> > arch/arm/mach-mx5/board-dt.c | 94
> > ++++++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 94 insertions(+), 0 deletions(-)
> >
> >diff --git a/arch/arm/mach-mx5/board-dt.c b/arch/arm/mach-mx5/board-dt.c
> >index 45d1e37..4850251 100644
> >--- a/arch/arm/mach-mx5/board-dt.c
> >+++ b/arch/arm/mach-mx5/board-dt.c
> >@@ -31,6 +31,97 @@
> >
> > #include "devices.h"
> >
> >+static iomux_v3_cfg_t mx51babbage_pads[] = {
> >+ /* UART1 */
> >+ MX51_PAD_UART1_RXD__UART1_RXD,
> >+ MX51_PAD_UART1_TXD__UART1_TXD,
> >+ MX51_PAD_UART1_RTS__UART1_RTS,
> >+ MX51_PAD_UART1_CTS__UART1_CTS,
[...]
> >+};
>
> This data already exists, so you should not duplicate it here.
>
So you are suggesting remove the 'static' where is first defined, and
refer to it here directly? Correct me if I misunderstood you comment.
> Iomux setup is a good candidate for a DT binding as it is just data,
> but I never came up with a good solution that was not bloated with a
> 32-bit value for every setting of each pin.
>
Honestly, this is something new for me, and I never thought about it,
but will, if later we all think this is something we should do.
--
Regards,
Shawn
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
