On Wednesday 09 March 2011 03:32:35 John Stultz wrote:
> In looking at trying to replace defconfigs with kconfig fragments,
> one limitation identified is that config items in choice blocks
> cannot be selected by other config options.
>
> One way to doge this would be to create non-visible meta options
> that change the choice block's default, but that would require
> additional meta-configs per-choice config, plus a conditional
> default per meta-config. That just seemed too ugly.
>
> So I looked into how to allow the choice default to be overrided
> by a select statment, and the following patch is the result.
>
> I'm very new to kconfig code, so I expect that my changes are
> probably broken in some subtle way, but in my testing it seems
> to work. The select only chagnes the default, which can be overrided
> by the user via the menu. This allows kconfig fragments to work
> for make defconfig, while not restricting user customization.
>
> Thoughts and feedback (or alternate approaches) would be appreciated.
>
> thanks
> -john
>
> CC: Grant Likely <grant.lik...@secretlab.ca>
> CC: Jason Hui <jason....@linaro.org>
> CC: patc...@linaro.org
> Signed-off-by: John Stultz <john.stu...@linaro.org>
The patch looks fine to me (as far as my little Kconfig
knowledge goes). Two comments about the submission form though:
* Ideally, the initial description is split into two parts: one
that is suitable as a changelog and the other that is your
personal comment, including the "thanks" part, and put it below
the --- line, so that git can automatically cut it.
* I think you should also Cc the Kconfig maintainer, Roman
Zippel <zip...@linux-m68k.org>, and linux-kbu...@vger.kernel.org.
Arnd
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
