On 21 February 2011 14:40, Jason Kridner <jkrid...@beagleboard.org> wrote:
> On Sun, Feb 20, 2011 at 8:19 PM, Jim Huang <js...@0xlab.org> wrote:
>> 2011/2/20 Jason Kridner <jkrid...@beagleboard.org>:
>>> Am I the only one for which the word "android" before "device" in the 
>>> subject would really help?
>>>
>>
>> hi Jason,
>>
>> I agree with you.  However, if we do "git am" the patch with subject
>> prefixing "android: ", every git
>> log would start with "android: ", right?  It sounds a bit annoying.
>
> How about putting it inside the [PATCH xxx], ie. "[PATCH v3 android]
> device/linaro/beagleboard: Install 0xbench native applications"?  When
> I go to git.linaro.org, this would give me enough information to
> figure out to which tree this patch applied.  For that matter, isn't
> "device/linaro/beagleboard" redundant as a comment within that tree?
> Why not just do "[PATCH v3 android/device/linaro/beagleboard] Install
> 0xbench native applications"?

Let us do the way Jason suggest from now on (at least until we have gerrit).

 /Patrik


>
>>
>>> On Feb 18, 2011, at 10:18 AM, Jeremy Chang <jeremy.ch...@linaro.org> wrote:
>>>
>>>> Signed-off-by: Jeremy Chang <jeremy.ch...@linaro.org>
>>>> ---
>>>> ZeroXBenchmark.mk |   96 
>>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>> beagleboard.mk    |    6 +++-
>>>> 2 files changed, 101 insertions(+), 1 deletions(-)
>>>> create mode 100644 ZeroXBenchmark.mk
>>>>
>>>> diff --git a/ZeroXBenchmark.mk b/ZeroXBenchmark.mk
>>>> new file mode 100644
>>>> index 0000000..e78047d
>>>> --- /dev/null
>>>> +++ b/ZeroXBenchmark.mk
>>>> @@ -0,0 +1,96 @@
>>>> +UNIXBENCH_BENCH_APPS :=         \
>>>> +    bench_ubench_hanoi          \
>>>> +    bench_ubench_syscall        \
>>>> +    bench_ubench_context1       \
>>>> +    bench_ubench_pipe           \
>>>> +    bench_ubench_spawn          \
>>>> +    bench_ubench_execl          \
>>>> +    bench_ubench_looper         \
>>>> +    bench_ubench_fstime         \
>>>> +    bench_ubench_arithoh        \
>>>> +    bench_ubench_register       \
>>>> +    bench_ubench_short          \
>>>> +    bench_ubench_int            \
>>>> +    bench_ubench_long           \
>>>> +    bench_ubench_float          \
>>>> +    bench_ubench_double         \
>>>> +    bench_ubench_dhry2          \
>>>> +    bench_ubench_dhry2reg       \
>>>> +    bench_ubench_whetstone-double
>>>> +
>>>> +LIBMICRO_BENCH_APPS :=          \
>>>> +    bench_getpid                \
>>>> +    bench_bind                  \
>>>> +    bench_cascade_mutex         \
>>>> +    bench_cascade_fcntl         \
>>>> +    bench_cascade_flock         \
>>>> +    bench_chdir                 \
>>>> +    bench_close                 \
>>>> +    bench_close_tcp             \
>>>> +    bench_connection            \
>>>> +    bench_dup                   \
>>>> +    bench_exec                  \
>>>> +    bench_exit                  \
>>>> +    bench_exp                   \
>>>> +    bench_fcntl                 \
>>>> +    bench_fcntl_ndelay          \
>>>> +    bench_file_lock             \
>>>> +    bench_fork                  \
>>>> +    bench_getenv                \
>>>> +    bench_gettimeofday          \
>>>> +    bench_getpeername           \
>>>> +    bench_getrusage             \
>>>> +    bench_getsockname           \
>>>> +    bench_isatty                \
>>>> +    bench_listen                \
>>>> +    bench_localtime_r           \
>>>> +    bench_log                   \
>>>> +    bench_longjmp               \
>>>> +    bench_lrand48               \
>>>> +    bench_lseek                 \
>>>> +    bench_malloc                \
>>>> +    bench_memcpy                \
>>>> +    bench_memmove               \
>>>> +    bench_memrand               \
>>>> +    bench_memset                \
>>>> +    bench_mktime                \
>>>> +    bench_mprotect              \
>>>> +    bench_mmap                  \
>>>> +    bench_msync                 \
>>>> +    bench_munmap                \
>>>> +    bench_mutex                 \
>>>> +    bench_nop                   \
>>>> +    bench_open                  \
>>>> +    bench_pipe                  \
>>>> +    bench_poll                  \
>>>> +    bench_pread                 \
>>>> +    bench_pthread_create        \
>>>> +    bench_pwrite                \
>>>> +    bench_read                  \
>>>> +    bench_realpath              \
>>>> +    bench_recurse               \
>>>> +    bench_select                \
>>>> +    bench_setsockopt            \
>>>> +    bench_sigaction             \
>>>> +    bench_siglongjmp            \
>>>> +    bench_signal                \
>>>> +    bench_sigprocmask           \
>>>> +    bench_socket                \
>>>> +    bench_socketpair            \
>>>> +    bench_stat                  \
>>>> +    bench_strcasecmp            \
>>>> +    bench_strchr                \
>>>> +    bench_strcmp                \
>>>> +    bench_strcpy                \
>>>> +    bench_strftime              \
>>>> +    bench_strlen                \
>>>> +    bench_strtol                \
>>>> +    bench_system                \
>>>> +    bench_time                  \
>>>> +    bench_times                 \
>>>> +    bench_write                 \
>>>> +    bench_writev
>>>> +
>>>> +ZEROXBENCHMARK_NATIVE_APPS :=   \
>>>> +    $(UNIXBENCH_BENCH_APPS)     \
>>>> +    $(LIBMICRO_BENCH_APPS)
>>>> diff --git a/beagleboard.mk b/beagleboard.mk
>>>> index c10e0fa..f810f36 100644
>>>> --- a/beagleboard.mk
>>>> +++ b/beagleboard.mk
>>>> @@ -1,5 +1,7 @@
>>>> # The beagleboard product that is specialized for beagleboard.
>>>>
>>>> +include $(LOCAL_PATH)/ZeroXBenchmark.mk
>>>> +
>>>> PRODUCT_PACKAGES := \
>>>>     ZeroXBenchmark \
>>>>     libmicro \
>>>> @@ -22,7 +24,9 @@ PRODUCT_PACKAGES := \
>>>>     Sync \
>>>>     Updater \
>>>>     CalendarProvider \
>>>> -    SyncProvider
>>>> +    SyncProvider \
>>>> +    $(ZEROXBENCHMARK_NATIVE_APPS)
>>>> +
>>>>
>>>> $(call inherit-product, $(SRC_TARGET_DIR)/product/core.mk)
>>>>
>>>> --
>>>> 1.7.1
>>
>
> _______________________________________________
> linaro-dev mailing list
> linaro-dev@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/linaro-dev
>

_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev

Reply via email to