On Sat, 2011-02-19 at 02:54 +0900, sola wrote: > From 7784102e184c134eaa11b5986f31c892748f1604 Mon Sep 17 00:00:00 2001 > From: Masashi YOKOTA <yok...@pylone.jp> > Date: Sat, 19 Feb 2011 02:40:56 +0900 > Subject: [PATCH 1/2] Add virtual battery driver > > This patch adds virtual battery driver. > This is based on > git://git.linaro.org/people/jstultz/linux.git dev/linaro.android > > Signed-off-by: Masashi YOKOTA<yok...@pylone.jp> > Signed-off-by: Akihiro MAEDA <sola.198...@gmail.com>
This looks pretty good! Although I have one more concern: Since it wasn't in the last version of the patch, did you add Masashi YOKOTA's signed-off-by line? If the original patch did not have his signed-off by line, you should not add it (and from my searching, it doesn't seem like it was originally made available as a patch, but as a driver tarball). Also, just to be clear about what the "Signed-off-by" means, you might want to review the "Developer's Certificate of Origin" section found under the "Sign your work" section of Documentation/SubmittingPatches. While not required by the GPL, as a courtesy you may want to bring Masashi YOKOTA into the discussion by CC'ing him the next time you submit this patch (as well as on your changes). So re-submit the patch one more time after you have done the above, and I should be able to merge it. thanks -john _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
