On Tue, 8 Feb 2011, [email protected] wrote:
> From: Thomas Abraham <[email protected]>
>
> The length of memory resource definition for UART devices in all the
> s5p platforms is one byte more than the intended value. This patch
> fixes the UART memory resource definition for all s5p platforms.
>
> Signed-off-by: Thomas Abraham <[email protected]>
> ---
> arch/arm/mach-s5p6442/include/mach/map.h | 2 +-
> arch/arm/mach-s5p64x0/include/mach/map.h | 2 +-
> arch/arm/mach-s5pc100/include/mach/map.h | 2 +-
> arch/arm/mach-s5pv210/include/mach/map.h | 2 +-
> arch/arm/mach-s5pv310/include/mach/map.h | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-s5p6442/include/mach/map.h
> b/arch/arm/mach-s5p6442/include/mach/map.h
> index 203dd5a..59464f9 100644
> --- a/arch/arm/mach-s5p6442/include/mach/map.h
> +++ b/arch/arm/mach-s5p6442/include/mach/map.h
> @@ -46,7 +46,7 @@
> #define S5P_PA_UART0 (S5P6442_PA_UART + 0x0)
> #define S5P_PA_UART1 (S5P6442_PA_UART + 0x400)
> #define S5P_PA_UART2 (S5P6442_PA_UART + 0x800)
> -#define S5P_SZ_UART SZ_256
> +#define S5P_SZ_UART (SZ_256 - 1)
[...]
This is wrong. I'm sure the _size_ is actually 256. In the resource
definition it is not a size but a boundary that is required. So it is
not the S5P_SZ_UART definition that needs fixing but rather its usage.
For example:
.start = S5P6442_PA_PDMA,
.end = S5P6442_PA_PDMA + SZ_4K,
This is wrong. you should have instead:
.start = S5P6442_PA_PDMA,
.end = S5P6442_PA_PDMA + SZ_4K - 1,
And so on where S5P_SZ_UART is used.
Nicolas
_______________________________________________
linaro-dev mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/linaro-dev
