Dnia wtorek, 16 listopada 2010 o 12:46:39 Amit Arora napisał(a):
> As part of the Power Management Work Group, I have been developing a
> new tool called PowerDebug which can show users/developers information
> on regulators, senors and clock tree. Its time now to package it for
> Ubuntu (since, Linaro will pick up the package from Ubuntu repo.). We
> also plan to host a project in LaunchPad for this tool.
> I am new to Ubuntu and debian way of packaging. Still, have given a
> shot at packaging PowerDebug and have put it in my git tree hosted at
>
> : git://git.linaro.org/people/amitarora/powerdebug.git in the branch
>
> called "debian". The "master" branch has only the source code for the
> tool.
> If you have fare idea about .deb packaging, I will request you to
> please review these files and suggest any changes that may be
> required. I have also uploaded this under my ppa
> (ppa:amitarora/pm-utils).
I had a look at packaging. My changes are small and nearly cosmetic:
23:02 h...@home:powerdebug$ git diff
diff --git a/debian/changelog b/debian/changelog
index 9b8774e..feadc7f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,5 @@
powerdebug (0.5) maverick; urgency=low
+
* Fix coding style issues and some more cleanups
* Discover debugfs mount point and remove hard coded path
* Display clock tree in ncurses mode using in-memory data structures
@@ -6,6 +7,7 @@ powerdebug (0.5) maverick; urgency=low
-- Amit Arora <amit.ar...@linaro.org> Tue, 16 Nov 2010 16:24:07 +0530
powerdebug (0.4) maverick; urgency=low
+
* Read clocks into memory and add dump support
* Show all regulators and clocks by default
* Discover debugfs mount point at runtime
I do not know does empty line after version is required but most of packages
which I was working with had them. It also makes changelogs easier to read.
diff --git a/debian/control b/debian/control
index 311a527..d69f6ed 100644
--- a/debian/control
+++ b/debian/control
@@ -2,13 +2,13 @@ Source: powerdebug
Section: utils
Priority: optional
Maintainer: Amit Arora <amit.ar...@linaro.org>
-Build-Depends: cdbs, debhelper (>= 7), libncursesw5-dev, libncurses5-dev
-Standards-Version: 3.8.4
-Homepage: <insert the upstream URL, if relevant>
+Build-Depends: cdbs, debhelper (>= 7), libncurses5-dev
+Standards-Version: 3.9.1
Package: powerdebug
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: This tool displays regulator, sensor and clock information.
- PowerDebug refreshes this information every few seconds. You can
- also use dump option to display the information just once.
+Description: tool to display regulator, sensor and clock information
+ PowerDebug is a tool to display regulator, sensor and clock information.
+ Information are refreshed every few seconds. You can also use dump option to
+ display the information just once.
1. libncursesw5-dev build time dependency is bogus - you link with "-lncurses"
which I think is fine until you will get CJKV translation.
2. Homepage got dropped, but if there is any then add it.
3. Standards-version 3.8.4 is old and lintian complains about it.
4. Description does not have to be a sentence. And some tools shows only
extended one so there is a bit of repeating...
5. Consider syncing README with debian/control - descriptions in both differ.
Regards,
--
JID: h...@jabber.org
Website: http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
