On Tue, 2010-10-19 at 14:47 +0800, Shawn Guo wrote:
> This patch are based on Eric Bénard's patches below, and only
> picks up i.mx51 babbage specific bits.
>
> - cpuimx51: update board support
> - clock-mx51: factorize clk_set_parent and clk_get_rate
> - imx-esdhc: update devices registration
Hey Shawn!
First of all, thanks so much for your recent work here! Today, with
your patches, I finally got my imx51 board booting with the latest
linaro image! This has been a long time stumbling block for me, so I'm
really glad its finally coming together!
Stuff that still needs to be addressed:
---------------------------------------
* mmcinfo needs to be called to avoid mmc hangs. (bug 655461)
* uboot in the hardware pack doesn't seem to utilize the boot.scr by
default (likely due to the issue above).
* Latest hardware pack from today doesn't seem to have the kernel
changes from git://git.linaro.org/kernel/linux-linaro-2.6.35.git, to
enable the sd/mmc device, so I had to build my own kernel.
* /bin/auto-serial-console: tty[A-Z]* --> tty[a-zA-Z]*
* fec ethaddr issue (bug 652426). Can you attach the patch you listed in
the bug? I wanted to test it, but trying to pulling it from the comment
ends up with too much whitespace damage.
And just a heads up:
I while rebasing the imx patches in the linaro tree against Linus'
upstream kernel, I noticed this patch has some pretty bad whitespace
damage, which will need to be fixed up before pushing to mainline. For
example, notice the extra space before the braces in the following:
> +static int _clk_ccgr_enable(struct clk *clk)
> {
> - u32 reg;
> -
> - reg = __raw_readl(clk->enable_reg);
> - reg &= ~(MXC_CCM_CCGRx_CG_MASK << clk->enable_shift);
> - reg |= MXC_CCM_CCGRx_MOD_IDLE << clk->enable_shift;
> - __raw_writel(reg, clk->enable_reg);
> + _clk_ccgr_setclk(clk, MXC_CCM_CCGRx_MOD_ON);
> + return 0;
> + }
> +
> + static void _clk_ccgr_disable(struct clk *clk)
> + {
> + _clk_ccgr_setclk(clk, MXC_CCM_CCGRx_MOD_OFF);
> }
> +
> +static int _clk_ccgr_enable_inrun(struct clk *clk)
> +{
> + _clk_ccgr_setclk(clk, MXC_CCM_CCGRx_MOD_IDLE);
> + return 0;
> + }
> +
> + static void _clk_ccgr_disable_inwait(struct clk *clk)
> + {
> + _clk_ccgr_setclk(clk, MXC_CCM_CCGRx_MOD_IDLE);
> + }
thanks again for the great work!
-john
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
