Hi Alexandros,

I found a bug in clutter for gles. And I have prepared a patch as attached.
Could you please add it to our clutter branch? I think this patch should
also be upstreamable.

By the way, could you please give some tips here to contribute to the
upstream clutter?

Regards,
Jammy
From 9a791927102de674829b184ee20bbbbc80411c58 Mon Sep 17 00:00:00 2001
From: Jammy Zhou <jammy.z...@linaro.org>
Date: Sun, 19 Sep 2010 16:22:29 +0800
Subject: [PATCH 1/1] cogl-framebuffer.c: GL_DEPTH_STENCIL not supported in gles

There is GL_INVALID_ENUM error for GL_DEPTH_STENCIL when call
glRenderbufferStorage() with OpenGL ES backend.
---
 clutter/cogl/cogl/cogl-framebuffer.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/clutter/cogl/cogl/cogl-framebuffer.c b/clutter/cogl/cogl/cogl-framebuffer.c
index 7d3689b..07b5b01 100644
--- a/clutter/cogl/cogl/cogl-framebuffer.c
+++ b/clutter/cogl/cogl/cogl-framebuffer.c
@@ -479,7 +479,9 @@ cogl_offscreen_new_to_texture (CoglHandle texhandle)
 
   if ((have_working_flags &&
        try_creating_fbo (offscreen, flags, texhandle)) ||
+#ifdef HAVE_COGL_GL
       try_creating_fbo (offscreen, flags = _TRY_DEPTH_STENCIL, texhandle) ||
+#endif
       try_creating_fbo (offscreen, flags = _TRY_DEPTH | _TRY_STENCIL,
                         texhandle) ||
       try_creating_fbo (offscreen, flags = _TRY_STENCIL, texhandle) ||
-- 
1.7.0.4

_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev

Reply via email to