Sorry, keep forgetting to "reply-all"...
---------- Forwarded message ---------
From: Kees van den Doel <kvd...@gmail.com>
Date: Mon, Aug 2, 2021 at 9:24 AM
Subject: Re: Persian music package
To: Thomas Morley <thomasmorle...@gmail.com>


Too many things wrong with that, starting with missing sori symbol, wrong
koron symbol in key signature.
 'v' should affect only MIDI etc. The example mehr.ly  in the example/ in
my zip file is a better test, shur.ly I just posted to illustrate unmetered
notes.

Cheers,
Kees
Kees

On Mon, Aug 2, 2021 at 9:10 AM Thomas Morley <thomasmorle...@gmail.com>
wrote:

> Am So., 1. Aug. 2021 um 20:13 Uhr schrieb Kees van den Doel <
> kvd...@gmail.com>:
> >
> >
> >
> > On Sun, Aug 1, 2021 at 10:40 AM Kees van den Doel <kvd...@gmail.com>
> wrote:
> >>
> >>
> >>
> >> On Sun, Aug 1, 2021 at 2:29 AM Thomas Morley <thomasmorle...@gmail.com>
> wrote:
> >>>
> >>>
> >>> Furthermore I'd replace the override for Accidental.extra-offset by:
> >>>     \override Accidental.Y-offset =
> >>
> >>
> >> Typo I assume and you mean "\override Accidental.extra-offset ="?
> >>
> >>>
> >>>       #(lambda (grob)
> >>>           (cdr
> >>>             (assoc-get
> >>>               (ly:grob-property grob 'alteration)
> >>>               persianStringsOffsets)))
> >>>
> >> That doesn't work because now you take the cdr twice. I think
> (assoc-get ... is the same as (cdr (assoc .. isn't it?
> >> But assoc-get without cdr is nicer of course, didn't know about that.
> >
> >
> > No that doesn't work, I must not understand something. Can you explain
> why you suggest the change? If I keep the cdr as in your example it runs
> but  offsets are no longer right.  It works fine with assoc.
> >
> > Cheers,
> > Kees
>
> Well, I overlooked you defined an alist for use with extra-offset,
> requiring pairs. Whereas I proposed not to move accidentals in X-axis,
> but only in Y-axis direction. Thus Y-offset requiring only a number.
>
> Alas, I feel it's all a bit clumsy, instead I followed Hans advice to
> use smufl-glyphs.
> A _partial_ and basic rewrite of your persian.ly is attached (with
> examples).
> I use stuff from
>
> https://github.com/openlilylib/snippets/blob/master/custom-music-fonts/smufl/definitions.ily
> and
>
> https://github.com/openlilylib/snippets/blob/master/custom-music-fonts/smufl/smufldata.ily
>
> You will need the Bravura-font, downlaodable at:
> http://www.smufl.org/fonts/
> (put it in lilypond/usr/share/lilypond/current/fonts/otf/)
> and the mapping file smufldata.ily, attached as well.
>
> Hope I didn't forget anything.
> If anything is not working it may be not implemented yet...
> If so (or a different problem), please post the failing example as a
> compilable ly-file
>
> Cheers,
>   Harm
>

Reply via email to