I have a question (I'm not very familiar w/ guile2 and lilypond source
structure), but is it possible to build with guile1 and run with guile2,
and vice-versa?
Em ter., 5 de out. de 2021 às 16:42, Jefferson Felix <jsfe...@gmail.com>
escreveu:
> I just did this change locally, only the message is different (running
> Guile 2), because someone also can build from source using guile 2.
>
> I agree with this solution.
>
> Em ter., 5 de out. de 2021 às 15:25, Jean Abou Samra <j...@abou-samra.fr>
> escreveu:
>
>> [Lukas]
>> > Would it be considered reasonable to hard-wire a special
>> > startup message in LilyPond proper if it is being built
>> > with Guile2 (or rather: detects guile-2 on startup)?
>>
>>
>> I like the principle. However, Homebrew seems to want versioned
>> tarballs, and I am not sure Phil and Jonas should have to go
>> through the multi-hour release process for this.
>>
>>
>> [Felix]
>> > Yes, exactly. We don't use patches and code replacements are avoided as
>> > much as possible.
>>
>>
>> How about making an exception? After all, what is the purpose
>> of avoiding code replacements in the first place? Presumably
>> that's in order not to introduce own bugs and not to have to
>> maintain the code in parallel. Applying something like the
>> following should be rather safe in this regard.
>>
>> diff --git a/lily/lily-version.cc b/lily/lily-version.cc
>> index 3d2b268b0a..f946750821 100644
>> --- a/lily/lily-version.cc
>> +++ b/lily/lily-version.cc
>> @@ -21,6 +21,7 @@
>>
>> #include "config.hh"
>> #include "version.hh"
>> +#include "lily-guile.hh"
>>
>> using std::string;
>>
>> @@ -45,6 +46,9 @@ string
>> gnu_lilypond_version_string ()
>> {
>> string str = gnu_lilypond_string () + " " + version_string ();
>> + #if GUILEV2
>> + str = str + " with Guile 2 (from Homebrew)";
>> + #endif
>> return str;
>> }
>>
>> Thanks,
>> Jean
>>
>
>
> --
> ---
> Jefferson dos Santos Felix
>
--
---
Jefferson dos Santos Felix
