On 2020/03/25 08:45:31, davidsg wrote: > Patch description in the issue tracker has been updated. > > https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc > File lily/vowel-transition.cc (right): > > https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc#newcode37 > lily/vowel-transition.cc:37: SCM num_length = me->get_property > ("minimum-length"); > On 2020/03/24 21:46:30, hanwenn wrote: > > num suggests a number. > > > > minimum_length ? > > Done. > > https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc#newcode137 > lily/vowel-transition.cc:137: w += -d * r->item_drul_[d]->extent > (r->item_drul_[d], X_AXIS)[-d]; > On 2020/03/24 21:46:29, hanwenn wrote: > > this still looks strange, but if it's problem, it'll be contained within the > > vowel-transition code, which is acceptable. > > Acknowledged, thanks.
this went into master. Can you close the review? https://codereview.appspot.com/565750043/
