On 2020/02/04 20:35:40, Dan Eble wrote:
> I'm running some of my patches through clang-format as I prepare to
push them.
> 
> This is an example of a kind of change it wants to make:
> 
> -  const array<int, 2> key {column_rank, dir};
> +  const array<int, 2> key{column_rank, dir};
> 
> Note the space after key.  The setting that controls this is
> SpaceBeforeCpp11BracedList.  Am I correct that we should use a space
here for
> consistency with historical style?
> 
> More examples of the effect of the option are in the docs:
>
https://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormatStyleOptions.html

historically, we didn't have C++11, so this wasn't an issue. I'm fine
with whatever you pick.

With the space seems more coherent with the s p a c e y  GNU style. 

https://codereview.appspot.com/561340043/

Reply via email to