On 2020/02/01 20:55:22, Dan Eble wrote: > On 2020/02/01 20:10:15, hanwenn wrote: > > Can I ask that we don't do this on a code review, but in a separate thread? > > Why? The review is where the patch meister (James) looks when he decides > whether to advance the patch through the countdown. If there were no activity > here, he might advance the patch to push, not recognizing that it is > controversial.
I marked it DO NOT SUBMIT. We should discuss it separately, because likely the discussion will touch on an wider issue of C++ style and future plans for the code base, and doesn't pertain to this small change of the code. https://codereview.appspot.com/577440044/
