On Sat, Sep 21, 2019 at 5:52 AM Jonas Hahnfeld via lilypond-devel < lilypond-devel@gnu.org> wrote: > On top of that I've worked on the attached patches which brings the make targets check / test and doc back to life with Python 3.7.4.
In applying your patches and running "make check", I encountered a couple of errors in scripts/build/output-distance.py, which would be summed up as: 1. Python 2 old style classes had a default __cmp__ which would compare the id() of the classes, and used implicitly for sort. Python 3 removed this, but need to define a __lt__ method for sort compat. 2. attempting to open midi files as str files, though they are filled with binary data (and python/midi.py seems to expect binary in interacting with the contents). Please see the attached for small patches for these two things, and got "make check" to run for me using Python 3.7.4 as well. Regards, Matt
0001-add-__lt__-method-for-py2-old-style-class-sort-compa.patch
Description: Binary data
0002-read-midi-files-as-binary.patch
Description: Binary data
_______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
