On 2019/04/26 18:49:03, dak wrote:
mailto:hanw...@gmail.com writes:

> add a regression test?
>
> https://codereview.appspot.com/576610043/

I am not sure what the point of it would be.  This kind of bug may be
present elsewhere (and the regression test would not cover that) and
it
is not likely to get reintroduced here since this code does not really
interact with other code.  And if you try running the test on older
versions for comparison, it will just crash.  The visual output is
meaningless since the condition it protects against does not have
meaning.

After many years of developing software, I'm skeptic of any bugfix
without test, but yes, maybe it's overkill in this case? In any case, I
think there is a case in slur-configuration.cc too




https://codereview.appspot.com/576610043/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to