Reviewers: ,
Message:
This doesn’t change LilyPond’s default behaviour (well, except for some
slight horizontal spacing changes; the Ambitus hadn’t been centered
between LeftEdge and Clef). Should it because Ambitus after the
KeySignature makes more sense (looking at accidentals …) for some
people?
https://codereview.appspot.com/348050043/diff/1/ly/property-init.ly
File ly/property-init.ly (right):
https://codereview.appspot.com/348050043/diff/1/ly/property-init.ly#newcode34
ly/property-init.ly:34: ambitusAfterKeySignature = {
Is this the correct file for such a command? Also, I’m not sure whether
that’s the best name, it seems very long to me.
Description:
Issue 4396
This adds the command \ambitusAfterKeySignature to property-init.ly. I’m
not sure whether that’s the correct place, please review.
The command can be placed in a \layout block but not in \layout {
\context { \Staff … } } because it’s an override on Score level.
Maybe it should be a context mod (\with { … }) instead of music
expression?
The suggested change also improves ambitus’s horizontal spacing.
Please review this at https://codereview.appspot.com/348050043/
Affected files (+44, -4 lines):
M ly/property-init.ly
M scm/define-grobs.scm
Index: ly/property-init.ly
diff --git a/ly/property-init.ly b/ly/property-init.ly
index
d1ed3b335a2b624870a99db01c1257a2c31cf1f4..50c722492d229ab72a9fd7027f8f72df0e9233cf
100644
--- a/ly/property-init.ly
+++ b/ly/property-init.ly
@@ -29,6 +29,44 @@ piano styles, which use @samp{GrandStaff} as a context."
)
(*location*))
(make-music 'Music))))
+%% ambitus
+
+ambitusAfterKeySignature = {
+ \override Score.BreakAlignment.break-align-orders =
+ #'#((left-edge
+ cue-end-clef
+ breathing-sign
+ clef
+ cue-clef
+ staff-bar
+ key-cancellation
+ key-signature
+ ambitus
+ time-signature
+ custos)
+ (left-edge
+ cue-end-clef
+ breathing-sign
+ clef
+ cue-clef
+ staff-bar
+ key-cancellation
+ key-signature
+ ambitus
+ time-signature
+ custos)
+ (left-edge
+ breathing-sign
+ clef
+ key-cancellation
+ key-signature
+ ambitus
+ time-signature
+ staff-bar
+ cue-clef
+ custos))
+}
+
%% arpeggios
% For drawing vertical chord brackets with \arpeggio
Index: scm/define-grobs.scm
diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm
index
7b1ba038283ad6d74ed96c5fae1e93ec0d47af3f..51ae2c37154d7c0137309dc0bf4ee94fe682e34b
100644
--- a/scm/define-grobs.scm
+++ b/scm/define-grobs.scm
@@ -110,11 +110,11 @@
(non-musical . #t)
(space-alist . (
(cue-end-clef . (extra-space . 0.5))
- (clef . (extra-space . 0.5))
+ (clef . (extra-space . 1.15))
(cue-clef . (extra-space . 0.5))
(key-signature . (extra-space . 0.0))
- (staff-bar . (extra-space . 0.0))
- (time-signature . (extra-space . 0.0))
+ (staff-bar . (extra-space . 1.15))
+ (time-signature . (extra-space . 1.15))
(first-note . (fixed-space . 0.0))))
(X-extent . ,ly:axis-group-interface::width)
(Y-extent . ,axis-group-interface::height)
@@ -557,6 +557,7 @@
(non-musical . #t)
(space-alist . ((cue-clef . (extra-space . 2.0))
(staff-bar . (extra-space . 0.7))
+ (ambitus . (extra-space . 1.15))
(key-cancellation . (minimum-space . 3.5))
(key-signature . (minimum-space . 3.5))
(time-signature . (minimum-space . 4.2))
@@ -1267,6 +1268,7 @@
(flat-positions . (2 3 4 2 1 2 1))
(sharp-positions . (4 5 4 2 3 2 3))
(space-alist . (
+ (ambitus . (extra-space . 1.15))
(time-signature . (extra-space . 1.15))
(staff-bar . (extra-space . 1.1))
(cue-clef . (extra-space . 0.5))
@@ -1341,7 +1343,7 @@
(break-visibility . ,begin-of-line-visible)
(non-musical . #t)
(space-alist . (
- (ambitus . (extra-space . 2.0))
+ (ambitus . (extra-space . 1.15))
(breathing-sign . (minimum-space . 0.0))
(cue-end-clef . (extra-space . 0.8))
(clef . (extra-space . 0.8))
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
