On 2018/06/13 03:24:02, dan_faithful.be wrote:
I perceive that we understand each other’s points and simply disagree.
There is
nothing new I want to counter with. I will just state that if a
contributor
were made uncomfortable by dynamic_cast, my two-pronged solution would
be (1)
gently encourage him to educate himself on this fundamental feature of
C++, and
(2) over time, rework the software to require fewer casts by
preserving more
type information in the internal interfaces and pushing the casts
outward toward
the interface with Scheme.
I now understand more about the overhead that is involved in the encapsulation that I thought was desirable. Rather than an execution overhead, there is a coding overhead. For every type of dynamic cast I may want to use, I need to provide a getter method. And this just covers up a dynamic cast; there's not any reasonable error handling involved in the getter method. That's not very smart, I see now. I wholeheartedly agree with your changes. Thanks for running with this issue. Carl https://codereview.appspot.com/344010043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
