At any rate:

LGTM

I think that covariant return types predate C++11, right?


https://codereview.appspot.com/341320043/diff/20001/lily/system.cc
File lily/system.cc (right):

https://codereview.appspot.com/341320043/diff/20001/lily/system.cc#newcode449
lily/system.cc:449: dynamic_cast<Paper_column *> (c[j])->set_system
(system);
Not really in the scope of this patch/issue any more, but shouldn't c be
a vector<Paper_column *> and conversely Column_x_position (the type of
breaking[].cols_) ?

https://codereview.appspot.com/341320043/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to