I like the changes. Just a few more comments for clarification.
https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/input.itely#newcode2847 Documentation/notation/input.itely:2847: Note: @code{set-global-fonts} can change not only the notation fonts Maybe change the wording slightly: "Note: Each call to @code{set-global-fonts} completely resets both the main notation and text fonts. If any category is left unspecified, then the default font will be used for that category. Each call to @code{set-global-fonts} changes the fonts for each @code{\book} that follows it, whether created explicitly or implicitly. This means that each @code{\book} can have its own set of main fonts by calling @code{set-global-fonts} before it." https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/input.itely#newcode2881 Documentation/notation/input.itely:2881: Note: The only allowed font names must have the I would reword this to be a bit more specific so there's no confusion about what is/isn't expected: "Note: At the moment, LilyPond expects the font file names to have the following suffixes, all of which must be present in the above installation folder(s) to work properly:" The only caveat is that the user doesn't technically need to have BOTH the music font set (with the -11, -13, -14, -16, -18, -20, -23, and -26 suffixes) AND a brace font (with the -brace suffix) for one or the other to work, but the music font set must have a file for ALL of those suffixes and the brace font must have its suffix. The reason for this is that the internal functions are hard-wired to require this, but can be modified quite easily to allow for more flexibility in the number of music font files. They could also be changed so the brace font no longer needs its -brace suffix, but maybe it should be kept that way since there's only one brace font file. I have configured the functions to allow this on my machine and haven't seen any issues in functionality. https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/input.itely#newcode2884 Documentation/notation/input.itely:2884: That is, @file{@var{fontname}-11.otf}, @file{@var{fontname}-20.svg}, I think it makes sense to be specific here, with something like "For example, @file{emmentaler-11.otf}" instead of "That is, @file{@var{fontname}-11.otf}". https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/text.itely#newcode1618 Documentation/notation/text.itely:1618: as the above @code{make-pango-font-tree} example. Since users are now using other music fonts, I think we better add a note to make-pango-font-tree that says this resets the music font to Emmentaler so that no one is surprised when this happens. Should make-pango-font-tree be deprecated in favor of set-global-fonts? https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/text.itely#newcode1644 Documentation/notation/text.itely:1644: #:brace "emmentaler" ; default It is important to note that the user does NOT specify the suffix of the font (e.g, "emmentaler-18" and "emmentaler-brace"), only the root font _file name_ "emmentaler" and NOT the internal font name "Emmentaler". The suffixes are added internally when the font tree is being created and looking up the font files. A simple note to say the suffixes are not needed (indeed, will cause an error if given) would suffice, IMO. This only applies to the #:music and #:brace strings. The text fonts expect the internal font names. https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/text.itely#newcode1654 Documentation/notation/text.itely:1654: Each call of @code{set-global-fonts} affects only the following book(s). Maybe reword this paragraph a little: "Each call of @code{set-global-fonts} affects each @code{\book} blocks that follow it. If there are multiple @code{\book} blocks and you want to use different fonts for each, simply call @code{set-global-fonts} again, like this:" https://codereview.appspot.com/330040043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
