On 2017/07/25 10:44:09, dak wrote:
On 2017/07/25 10:03:08, thomasmorley651 wrote:
> LGTM
>
> Though, wouldn't the rest-markup-command needed to be changed
accordingly?
Needed? No. The note-markup-command did not need to be changed
either. But
rest-markup-command _wants_ to be changed accordingly of course.
I was looking at it now. It is such an entangled mess that I don't
really know how to fix it. The problem is that multi-measure rests have
been wrapped into the same command, but the argument is interpreted
completely differently for multimeasure rests.
That would definitely have called for a separate command and stuff is so
entangled that I am somewhat at a loss how to pull it apart. There are
also some things that warrant code replacement for simplicity's sake,
like
;; Get the correct mmr-glyphs.
;; Store them in a list.
;; example:
;; (get-mmr-glyphs '(1 0 1 0) '("rests.M3" "rests.M2" "rests.M1"
"rests.0"))
;; -> ("rests.M3" "rests.M1")
- (define (get-mmr-glyphs lst1 lst2)
- (define (helper l1 l2 l3)
- (if (null? l1)
- (reverse l3)
- (helper (cdr l1)
- (cdr l2)
- (append (make-list (car l1) (car l2)) l3))))
- (helper lst1 lst2 '()))
+ (define (get-mmr-glyphs lst1 lst2) (append-map! make-list lst1 lst2))
https://codereview.appspot.com/328050043/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
