Am 18.01.2017 um 09:28 schrieb d...@gnu.org:

https://codereview.appspot.com/313240043/diff/160001/lily/parser.yy
File lily/parser.yy (right):

https://codereview.appspot.com/313240043/diff/160001/lily/parser.yy#newcode3107
lily/parser.yy:3107: $$ = $1;
That looks like strange fallback behavior.  EXTENDER likely has a value
of SCM_UNSPECIFIED (at least I think that is the default for tokens
without attached value).  Can the containing expression deal with that?

I actually had SCM_UNSPECIFIED without the warning in patchset 4 ... don't know
why I changed it. Surprisingly both work identically. But yes, it should be
SCM_UNSPECIFIED.

Knut
>From 7c89c556ca985925755c892873e787b9f223a5c3 Mon Sep 17 00:00:00 2001
From: Knut Petersen <knut_peter...@t-online.de>
Date: Wed, 18 Jan 2017 16:37:36 +0100
Subject: [PATCH] Change EXTENDER return value in parser

Signed-off-by: Knut Petersen <knut_peter...@t-online.de>
---
 lily/parser.yy | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lily/parser.yy b/lily/parser.yy
index 1c1b100db3..ecbcb2cd53 100644
--- a/lily/parser.yy
+++ b/lily/parser.yy
@@ -3104,7 +3104,7 @@ post_event_nofinger:
 		@$.warning (_ ("The '__' token is ignored and deprecated. Please "
                        "read \"Extenders and hyphens\" in section 2.1 "
                        "of the the notation manual!"));
-		$$ = $1;
+		$$ = SCM_UNSPECIFIED;
 
 	}
 	| script_dir direction_reqd_event {
-- 
2.11.0

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to