https://codereview.appspot.com/299250044/diff/1/scm/bar-line.scm File scm/bar-line.scm (right):
https://codereview.appspot.com/299250044/diff/1/scm/bar-line.scm#newcode30 scm/bar-line.scm:30: (define-public (calc-blot thickness extent grob) For a public function, the name is awful. When made public, the naming should be related to the functionality of the function from a general viewpoint rather than its function within this file only. Also I don't actually see how the "commit message" relates to making calc-blot public: "To facilitate defining custom-bar-lines using ly:round-filled-box" Huh? You mean, instead of having to use ly:round-filled-box directly? Because ly:round-filled-box should already be available anyway. Or something else? https://codereview.appspot.com/299250044/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
