----- Original Message -----
From: <d...@gnu.org>
To: <philehol...@googlemail.com>; <lily...@orange.fr>;
<em...@philholmes.net>
Cc: <re...@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Sunday, July 20, 2014 5:37 PM
Subject: Re: Changes from LSR doc run (issue 116040043
byphilehol...@googlemail.com)
https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly
File
Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly
(right):
https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly#newcode22
Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly:22:
%{ Original snippet :
An outcommented "original snippet"? If the original snippet is of
separate value, it should be a separate snippet.
https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly#newcode136
Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly:136:
%%%%%%%%%%%%%%%%%%%%%%% ATTENTION %%%%%%%%%%%%%%%%%%%%%%%%
Big block comments in French?
In this form I'd lean towards removing the snippet from the import list
if that's feasible.
https://codereview.appspot.com/116040043/
It is, but as a singer, I find that this is a valuable snippet. I'll tidy
it up in the LSR, so (as with the previous comment) I can't fix this patch,
but will fix the snippet in a following patch.
--
Phil Holmes
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
