LGTM except details
https://codereview.appspot.com/4609041/diff/29002/input/regression/ambitus-gap.ly File input/regression/ambitus-gap.ly (right): https://codereview.appspot.com/4609041/diff/29002/input/regression/ambitus-gap.ly#newcode5 input/regression/ambitus-gap.ly:5: note heads are set by the @code{gap} property. Also, ambitus line "By default, @code{gap} is a function that reduces the gap for small intervals, so line remains visible." We cannot say "Also," because if I set the gap property to 0.4, then the line will *not* be visible in fourth. https://codereview.appspot.com/4609041/diff/29002/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/4609041/diff/29002/scm/output-lib.scm#newcode1252 scm/output-lib.scm:1252: (if (and (ly:grob-array? heads) You should have an 'else' case (if <test> <body> <else>) so that if the test ever fails you return some value; otherwise the user gets a mysterious error message. https://codereview.appspot.com/4609041/diff/29002/scm/output-lib.scm#newcode1258 scm/output-lib.scm:1258: (max-gap (ly:grob-property grob 'maximum-gap 2)) The defaults seem strange. They should be typical values, otherwise people get confused. Is 'max-gap normally 2 ? https://codereview.appspot.com/4609041/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
