Frederic
On 23 August 2013 10:10, Frédéric Bron <frederic.b...@m4x.org> wrote: > > it does a make a make check (reg test comparison) and by default a full > make > > doc. > > Good point. I am preparing a large patch to replace 'string' by 'const > string&' where it makes sense (to avoid string copy when possible) and > although I am going to run make check my-self before submitting, I am > happy you double check. > > Cheers, > > Frédéric > I would at least normally expect that you do a 'make' to see that it builds against current tree - sometimes on the morning of the PATCH countdown, that is hard because someone may push a patch and the new tree is merged before the test scripts are run and you submitted a patch based on the tree before the push. That can cause make problems, but those are usually rare. Doing a make check is quite time consuming for some users and slow, so as long as you don't mind the potential wait for your patch to be tested (by me - others also run patchy but may not do the full make doc) think of it like just 'good manners' to do at _least_ a make ;) James
_______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
