Thanks for the review! On 2013/04/03 17:12:14, Trevor Daniels wrote:
Code not tested or even eye-balled.
If you're considering eye-balling it, i strongly recommend viewing it in a branch (dev/janek-alignment) - hopefully commit descriptions will help understand respective changes in the code. https://codereview.appspot.com/7768043/diff/76001/input/regression/unassociated-lyrics-alignment.ly File input/regression/unassociated-lyrics-alignment.ly (right): https://codereview.appspot.com/7768043/diff/76001/input/regression/unassociated-lyrics-alignment.ly#newcode12 input/regression/unassociated-lyrics-alignment.ly:12: \new Lyrics { \lyricmode { foo2 bar aaa1 mmm1 } } On 2013/04/03 17:12:14, Trevor Daniels wrote:
I see the durations on the syllables are the same as those on the notes. What happens if they differ? In particular if a syllable is placed between two notes?
Then the center of the syllable will be aligned to the appropriate point between these notes, much like Dynamics attached to spacer rests: \paper { ragged-right = ##f } { c'4\< c'\! d'\> e'\! << f'1 { s4 s4\< s4\> s4\! } >> } << { c'4 c' d' e' f'1 } \new Lyrics \lyricmode { <4 !4 >4 !4 \skip4 <4 >4 !4 } (output attached to tracker issue) Do you think that this should be part of the regtest? https://codereview.appspot.com/7768043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel