Trevor-- This looks great to me. I like the reordering, and I think the explanations are very clear.
I've tweaked the curves a little in the examples (do what you like with my suggestions!), but otherwise: LGTM. https://codereview.appspot.com/6561064/diff/6001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/6561064/diff/6001/Documentation/notation/changing-defaults.itely#newcode4014 Documentation/notation/changing-defaults.itely:4014: @end lilypond The PhrasingSlur looks a little distorted to me here. What about changing the example to something like this: \relative c'' { c8(\( a) a'4 e c\) \shape #'((0.8 . -0.5) (0.5 . -0.4) (0.3 . -0.3) (0 . -0.2)) Slur \shape #'((0 . 0) (0 . 0.5) (0 . 0.5) (0 . 0)) PhrasingSlur c8(\( a) a'4 e c\) } https://codereview.appspot.com/6561064/diff/6001/Documentation/notation/changing-defaults.itely#newcode4052 Documentation/notation/changing-defaults.itely:4052: @end lilypond I think the shaped PhrasingSlur should hug the contour of the line a little more closely here. I think this still shows collision avoidance working with the accent marks: \relative c'' { c8( e b-> f d' a e-> g) \shape #'((0 . -1) (5.5 . -0.5) (-5.5 . -10.5) (0 . -5.5)) PhrasingSlur c8\( e b-> f d' a e-> g\) } https://codereview.appspot.com/6561064/diff/6001/Documentation/notation/changing-defaults.itely#newcode4091 Documentation/notation/changing-defaults.itely:4091: @end lilypond I think that the slurs shouldn't touch the notes in the alternatives. Maybe the values here are too fine (whole numbers and 0.5 look nice as input), but see what you think: \relative c'' { c1 \repeat volta 3 { c4 d( e f } \alternative { { g2) d } { g2 % create a slur and move it to a new position -\tweak #'control-points #'((-2 . 3.7) (-1 . 4) (0 . 4) (1 . 3.4)) ( <> ) f, } { e'2 % create a slur and move it to a new position -\tweak #'control-points #'((-2 . 2.8) (-1 . 3.2) (0 . 3.2) (1 . 2.4)) ( <> ) f, } } } https://codereview.appspot.com/6561064/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
