Reviewers: Trevor Daniels,
Message:
http://codereview.appspot.com/6497103/diff/1/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
http://codereview.appspot.com/6497103/diff/1/Documentation/learning/fundamental.itely#newcode2921
Documentation/learning/fundamental.itely:2921: f16 ees f d g aes g f ees
d e8 ees16 f ees d |
On 2012/09/08 20:27:40, Trevor Daniels wrote:
Sorry James, the tie was correct. It's
the pitch that was wrong - should be ees8 ~
Done.
http://codereview.appspot.com/6497103/diff/1/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
http://codereview.appspot.com/6497103/diff/1/Documentation/learning/tweaks.itely#newcode1701
Documentation/learning/tweaks.itely:1701: be necessary to override this
automatic behavior. This can be done for
On 2012/09/08 20:27:40, Trevor Daniels wrote:
Don't need 2 spaces here
Done.
http://codereview.appspot.com/6497103/diff/1/Documentation/learning/tweaks.itely#newcode1702
Documentation/learning/tweaks.itely:1702: whole sections of music or
even for an individual note. The property
On 2012/09/08 20:27:40, Trevor Daniels wrote:
... or here
Done.
http://codereview.appspot.com/6497103/diff/1/Documentation/learning/tweaks.itely#newcode1703
Documentation/learning/tweaks.itely:1703: which controls this behavior
is the @code{direction} property of each
On 2012/09/08 20:27:40, Trevor Daniels wrote:
... or here
Done.
http://codereview.appspot.com/6497103/diff/1/Documentation/learning/tweaks.itely#newcode1705
Documentation/learning/tweaks.itely:1705: number of ready-made commands
which avoid your having to code explicit
On 2012/09/08 20:27:40, Trevor Daniels wrote:
... or here
Done.
Description:
Doc: Typos to LM - Fundamental and tweaks.itely
Issue 2791
Minor typos and clarifications.
Including an additional @ref{} and removal of (now) incorrect
information.
Please review this at http://codereview.appspot.com/6497103/
Affected files:
M Documentation/learning/fundamental.itely
M Documentation/learning/tweaks.itely
Index: Documentation/learning/fundamental.itely
diff --git a/Documentation/learning/fundamental.itely
b/Documentation/learning/fundamental.itely
index
01bb23e472423731807aeeab653efb93e13f32cb..732874c1bb64fd8486588f77d1fcdaf75af6cb65
100644
--- a/Documentation/learning/fundamental.itely
+++ b/Documentation/learning/fundamental.itely
@@ -2918,7 +2918,7 @@ ManualOneVoiceTwoMusic = \relative c' {
}
ManualTwoMusic = \relative c' {
c16 b c8~ c16 b c g a8 g~ g16 g aes ees |
- f16 ees f d g aes g f ees d e8~ ees16 f ees d |
+ f16 ees f d g aes g f ees d ees8~ ees16 f ees d |
}
PedalOrganMusic = \relative c {
r8 c16 d ees d ees8~ ees16 a, b g c b c8 |
Index: Documentation/learning/tweaks.itely
diff --git a/Documentation/learning/tweaks.itely
b/Documentation/learning/tweaks.itely
index
107cbaea99aa84c65834bee98043a48d1cd79567..f4210b2e0d8bfa711c239e011491ff745eee6d58
100644
--- a/Documentation/learning/tweaks.itely
+++ b/Documentation/learning/tweaks.itely
@@ -162,10 +162,9 @@ verbatim.
@tab direction, beam-thickness
@end multitable
-As we shall see shortly, the properties of different types of
-object are modified by different commands, so it is useful to
-be able to recognize the type of object from the names of its
-properties.
+As we shall see shortly, the properties of different types of object are
+modified by different commands, so it is useful to be able to recognize
+the types of objects and properties from their names.
@node Tweaking methods
@@ -570,10 +569,9 @@ this page, but if you have an idea about the name of
the layout object
to be tweaked, it is easier to go straight to the IR and search there.
This Slur page in the IR tells us first that Slur objects are created
-by the Slur_engraver. Then it lists the standard settings. Note
-these are @strong{not} in alphabetic order. Browse down them looking
-for a property that might control the heaviness of slurs, and you
-should find
+by the Slur_engraver. Then it lists the standard settings. Browse
+through them looking for a property that might control the heaviness of
+slurs, and you should find
@example
@code{thickness} (number)
@@ -654,7 +652,7 @@ Slur, where it says @q{Slur objects are created by: Slur
engraver}. So slurs will be created in whichever context
the @code{Slur_engraver} is in. Follow the link to the
@code{Slur_engraver} page. At the very bottom it tells
-us that @code{Slur_engraver} is part of five Voice contexts,
+us that @code{Slur_engraver} is part of seven Voice contexts,
including the standard voice context, @code{Voice}, so our
guess was correct. And because @code{Voice} is one of the
lowest level contexts which is implied unambiguously by
@@ -1285,7 +1283,7 @@ and to white it should be @code{(rgb-color 1 1 1)}:
@end lilypond
Finally, there is also a grey scale available as part of the
-X11 set of colors. These range from black, @code{'grey0'},
+X11 set of colors. These range from black, @code{'grey0},
to white, @code{'grey100}, in steps of 1. Let's illustrate
this by setting all the layout objects in our example to
various shades of grey:
@@ -1334,7 +1332,7 @@ found.
@cindex objects, changing size of
Let us begin by looking again at the earlier example
-see @ref{Nesting music expressions}) which showed
+(see @ref{Nesting music expressions}) which showed
how to introduce a new temporary staff, as in an @rglos{ossia}.
@cindex alignAboveContext property, example
@@ -1694,17 +1692,16 @@ this @q{nestling} of the notes on adjacent staves:
@node Within-staff objects
@subsection Within-staff objects
-We have already seen how the commands @code{\voiceXXX} affect
-the direction of slurs, ties, fingering and
-everything else which depends on the direction of the stems.
-These commands are essential when writing polyphonic music to
-permit interweaving melodic lines to be distinguished.
-But occasionally it may be necessary to override this automatic
-behavior. This can be done for whole sections of music or even
-for an individual note. The property which controls this
-behavior is the @code{direction} property of each layout object.
-We first explain what this does, and then introduce a number of
-ready-made commands which avoid your having to code explicit
+We have already seen how the commands @code{\voiceXXX} affect the
+direction of slurs, ties, fingering and everything else which depends on
+the direction of the stems -- see @ref{Explicitly instantiating voices}.
+These commands are essential when writing polyphonic music to permit
+interweaving melodic lines to be distinguished. But occasionally it may
+be necessary to override this automatic behavior. This can be done for
+whole sections of music or even for an individual note. The property
+which controls this behavior is the @code{direction} property of each
+layout object. We first explain what this does, and then introduce a
+number of ready-made commands which avoid your having to code explicit
overrides for the more common modifications.
Some layout objects like slurs and ties curve, bend or point
@@ -2179,7 +2176,7 @@ c2^"Text4" |
The command to revert to the default behavior is
@code{\textLengthOff}. Remember @code{\once} only works with
-@code{\override}, @code{\set}, @code{\revert} or @code{unset},
+@code{\override}, @code{\set}, @code{\revert} or @code{\unset},
so cannot be used with @code{\textLengthOn}.
@cindex markup text, allowing collisions
@@ -2220,7 +2217,7 @@ c''2 |
@cindex dynamics, tweaking placement
Dynamic markings will normally be positioned beneath the
-staff, but may be positioned above with the @code{dynamicUp}
+staff, but may be positioned above with the @code{\dynamicUp}
command. They will be positioned vertically relative to the
note to which they are attached, and will float below (or above)
all within-staff objects such as phrasing slurs and bar numbers.
@@ -2890,7 +2887,7 @@ Voice) need not be shifted away from the note column
of the higher
note. To correct this we set @code{force-hshift}, which is a property
of @code{NoteColumn}, of this note to zero.
-In the second chord we prefer the F to line up with the A and the
+In the second chord we prefer the F to line up with the A-flat and the
lowest note to be positioned slightly right to avoid a collision of
stems. We achieve this by setting @code{force-hshift} in the
@code{NoteColumn} of the low D-flat to move it to the right by half
@@ -3891,7 +3888,7 @@ will be displayed on the screen, we'll also increase
the
overall size of the output.
@example
-%%% definitions.ily
+%%% web-publish.ily
mpdolce =
#(make-dynamic-script
#@{ \markup @{ \hspace #0
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
