http://codereview.appspot.com/6496067/diff/1/lily/include/skyline.hh File lily/include/skyline.hh (right):
http://codereview.appspot.com/6496067/diff/1/lily/include/skyline.hh#newcode42 lily/include/skyline.hh:42: inline Real start () const { return start_; }; hmm... I personally would call that get_start() since I would expect start() to begin some process inside the object. (i.e. timer.start() ) http://codereview.appspot.com/6496067/diff/1/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/6496067/diff/1/lily/skyline.cc#newcode221 lily/skyline.cc:221: while (!s->empty () && start_x < b.end ()) is there any performance penalty for using a function call instead of a value directly? or does the C++ compiler optimize those out (especially since they're const ?) ? http://codereview.appspot.com/6496067/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
