----- Original Message -----
From: <[email protected]>
To: <[email protected]>; <[email protected]>; <[email protected]>
Cc: <[email protected]>; <[email protected]>
Sent: Sunday, March 04, 2012 4:50 PM
Subject: Re: Various updates to reduce make doc output (issue 5727055)
I think the scrips abc2ly and midi2ly are useful as stand-alone tools,
i.e. outside of the build system, in which case users might still expect
to see some progress messages. If that's the case then adding either a
--quiet or a --verbose option (or maybe --debug) for these scripts would
be nice; the build system would run them quietly of course.
Cheers,
Julien
I did consider it, but concluded that if you're running these tools, you
could probably look in the output directory to see what it's produced. It
just seemed more effort than it was worth, to be honest.
http://codereview.appspot.com/5727055/diff/1/Documentation/GNUmakefile
File Documentation/GNUmakefile (right):
http://codereview.appspot.com/5727055/diff/1/Documentation/GNUmakefile#newcode283
Documentation/GNUmakefile:283: cd $(outdir) &&
$(buildscript-dir)/run-and-check "$(LILYPOND_BINARY) --verbose
$(top-src-dir)/ly/generate-documentation" "$(*F).log"
Why not just call it "generate-documentation.log"
I did think of that, too! It actually produces internals.log, and I thought
that might fit better with the target. I used the make variable to be
relatively consistent with the other invocations.
http://codereview.appspot.com/5727055/diff/1/scripts/abc2ly.py
File scripts/abc2ly.py (left):
http://codereview.appspot.com/5727055/diff/1/scripts/abc2ly.py#oldcode1413
scripts/abc2ly.py:1413: sys.stderr.write ('Parsing `%s\'...\n' % f)
What about this line?
http://codereview.appspot.com/5727055/diff/1/scripts/abc2ly.py#oldcode1431
scripts/abc2ly.py:1431: sys.stderr.write ('\n')
And this line?
http://codereview.appspot.com/5727055/diff/1/scripts/midi2ly.py
File scripts/midi2ly.py (left):
http://codereview.appspot.com/5727055/diff/1/scripts/midi2ly.py#oldcode1030
scripts/midi2ly.py:1030: progress (_ ("%s output to `%s'...") % ('LY',
out_file))
Change it to a debug output?
http://codereview.appspot.com/5727055/diff/1/scripts/midi2ly.py#oldcode1030
scripts/midi2ly.py:1030: progress (_ ("%s output to `%s'...") % ('LY',
out_file))
Change it to a debug output maybe?
http://codereview.appspot.com/5727055/
_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
_______________________________________________
lilypond-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/lilypond-devel
