http://codereview.appspot.com/5651069/diff/5002/lily/note-collision.cc File lily/note-collision.cc (right):
http://codereview.appspot.com/5651069/diff/5002/lily/note-collision.cc#newcode191 lily/note-collision.cc:191: */ Protect the comment formatting with a column of '*'s Otherwise, someone might let emacs re-align the comment, as happened at line 543. http://codereview.appspot.com/5651069/diff/5002/lily/note-collision.cc#newcode536 lily/note-collision.cc:536: s[LEFT]--; // why LEFT and RIGHT instead of UP and DOWN? These lines first appeared in version 1.1.49, thirteen years ago. If you do not get answers to your questions during this review, you will probably have to find the answers yourself. http://codereview.appspot.com/5651069/diff/5002/lily/note-collision.cc#newcode551 lily/note-collision.cc:551: You can use `git blame` to find the original form of this comment <http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blob;f=lily/note-collision.cc;h=0354950a535f3856234e47a4e7904b2800cc9c09#l437> http://codereview.appspot.com/5651069/diff/5002/lily/note-collision.cc#newcode587 lily/note-collision.cc:587: for_UP_and_DOWN (d) Now we have both for_UP_and_DOWN and the while(flip()) idioms in LilyPond, so every time I forget what the difference is, I have to search for the definition, open a different file, and study an even more complicated loop construction. If you think that for_UP_or_DOWN was self-documenting, then better to : do // for d = UP, then DOWN { ... http://codereview.appspot.com/5651069/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
