LGTM, but a couple of minor comments.

http://codereview.appspot.com/5433065/diff/1/scm/define-grob-interfaces.scm
File scm/define-grob-interfaces.scm (right):

http://codereview.appspot.com/5433065/diff/1/scm/define-grob-interfaces.scm#newcode88
scm/define-grob-interfaces.scm:88: numbering-assertion-function))
spacing.  numbering-assertion-function should line up with footnote.  It
would be better, IMO, if footnote-text were on its own line, also
aligned with footnote.

http://codereview.appspot.com/5433065/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/5433065/diff/1/scm/define-grob-properties.scm#newcode1153
scm/define-grob-properties.scm:1153: (numbering-assertion-function
,scheme? "A function used to assert
Probably should say "The function", not "A function"

http://codereview.appspot.com/5433065/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to