LGTM apart from the way the error messages are phrased.
Cheers, Ian http://codereview.appspot.com/5361042/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/5361042/diff/1/scripts/build/output-distance.py#newcode836 scripts/build/output-distance.py:836: Re the error messages, how about if dirl.endswith("-baseline"); sys.stderr.write("Failed to walk through %s, you need to run make test-baseline before make-check.\n" % dir1) else: sys.stderr.write("Failed to walk through %s, cannot locate directory.\n" % dir1) sys.exit(1) I.e inform the user that he/she has screwed up, don't ask him/her questions or he/she will be less inclined to take your error messages seriously. Ian http://codereview.appspot.com/5361042/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
