http://codereview.appspot.com/5235052/diff/17001/lily/script-engraver.cc File lily/script-engraver.cc (right):
http://codereview.appspot.com/5235052/diff/17001/lily/script-engraver.cc#newcode206 lily/script-engraver.cc:206: Script_engraver::acknowledge_inline_accidental (Grob_info info) Doesn't this add every accidental to a script in a chord? I'm concerned there's a risk the side-positioning calculation might be incorrect, since the accidentals are shuffled around via AccidentalPlacement later. http://codereview.appspot.com/5235052/diff/17001/lily/side-position-interface.cc File lily/side-position-interface.cc (right): http://codereview.appspot.com/5235052/diff/17001/lily/side-position-interface.cc#newcode218 lily/side-position-interface.cc:218: b[ax] = e->maybe_pure_extent (common[ax], ax, pure, start, end); Accidentals have special treatment for more accurate boxes. Could you use them instead (or get the skyline from AccidentalPlacement instead)? http://codereview.appspot.com/5235052/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
