This passes make and make doc on my computer, without a scratch.
This is a great work, but it doesn't fit correctly into LilyPond:
* This should be put inside the parmesan font, like every ancient font:
noteheads in parmesan-noteheads, accidentals in parmesan-accidentals,
clef in parmesan-clefs, dot in parmesan-dots and the final "barline" in
parmesan-scripts
* Update 'note-head::calc-glyph-name' and 'select-head-glyph' in
scm/output-lib.scm so that it handles the kievan style.
* Add your new style to input/regression/note-head-style.ly
I also agree with Werner, there's also a lot of cleanup to do inside
your MetaFont stuff.
For example, you are using 15 dots for the flat glyph, but this could be
reduced to 5 or 6 dots.
Another example: there's a lot of common parts between your glyphs. We
can see it in such cases:
\markup \vspace #5
\markup \fontsize #15 {
\musicglyph #"kievan.u2kievan"
\scale #'(1 . -1) \musicglyph #"kievan.d2kievan"
}
95% of these glyphs is the same and could be merged.
In a general way, the idea with MetaFont is that you can easily see what
a glyph looks like by reading its code. Writing a bunch of dots with
hard-coded positions has no logical sense until you compile it. You have
to write your equations directly, instead of writing their results.
Again, thanks for having done this great work,
Bertrand
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf
File mf/feta-kievan.mf (right):
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode27
mf/feta-kievan.mf:27: fet_beginchar ("kievan quarter (down)",
"d4kievan");
"d2kievan" instead of "d4kievan"
We are using the duration log to select glyphs.
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode32
mf/feta-kievan.mf:32: x1 = 0.09 * staff_space;
In MetaFont, '=' stands for a mathematical equality.
Here, you are making an attribution, so ':=' would be better.
This comment is true for all your "[...] = [num] * staff_space;" lines.
Plus, you could use "z1 := (0.09 staff_space, 0.33 staff_space);" as you
correctly made later.
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode61
mf/feta-kievan.mf:61: fet_beginchar ("kievan quarter (up)", "u4kievan");
"u2kievan" (see previous comment)
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode91
mf/feta-kievan.mf:91: fet_beginchar ("kievan final note",
"sfinalkievan");
Why not using a fake duration log such as -2?
This is used for brevis noteheads.
So, this will give "sM2kievan" instead of "sfinalkievan".
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode124
mf/feta-kievan.mf:124: fet_beginchar ("kievan recitative mark",
"srecitative");
As for previous comment, I think "sM1kievan" would be better.
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode180
mf/feta-kievan.mf:180: fet_beginchar ("kievan half note (line
position)", "s2lkievan");
Use "s1kievan" instead.
This will use the selector I made for noteheads that are on line or
between lines (commit 0dcc93c0a5a97d048db2f7631966f41ae0059ab5).
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode205
mf/feta-kievan.mf:205: fet_beginchar ("kievan half note (space
position)", "s2skievan");
Use "s1rkievan" instead.
See previous comment.
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode231
mf/feta-kievan.mf:231: fet_beginchar ("kievan clef", "scleftsefaut");
"kievan.do" or "kievan.c3" instead of "scleftsefaut".
"Tse-Fa-Ut" can be written in the description.
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode271
mf/feta-kievan.mf:271: fet_beginchar ("kievan whole note", "s1kievan");
"s0kievan" (see earlier comment)
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode290
mf/feta-kievan.mf:290: fet_beginchar ("kievan eighth note (down)",
"d8kievan");
"d3kievan" (see earlier comment)
http://codereview.appspot.com/4951062/diff/41002/mf/feta-kievan.mf#newcode319
mf/feta-kievan.mf:319: fet_beginchar ("kievan eighth note (up)",
"u8kievan");
"u3kievan" (see earlier comment)
http://codereview.appspot.com/4951062/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
