I think LGTM, but it would be great if you'd add a regtest to demonstrate what this patch is fixing. (i was going to write "before/after pdfs attached to tracker issue would be priceless!" but i've just saw that you added them - perfect!)
thanks, Janek http://codereview.appspot.com/5030053/diff/9001/lily/mensural-ligature.cc File lily/mensural-ligature.cc (right): http://codereview.appspot.com/5030053/diff/9001/lily/mensural-ligature.cc#newcode79 lily/mensural-ligature.cc:79: stencil = Lookup::beam (corrected_slope, width * 0.5, staff_space, blotdiameter); What does this do? (sorry for a stupid question) http://codereview.appspot.com/5030053/diff/9001/lily/mensural-ligature.cc#newcode201 lily/mensural-ligature.cc:201: ("noteheads.sM2ligmensural").extent (Y_AXIS).length () * 0.5 I don't get it - why is this commented? http://codereview.appspot.com/5030053/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
