http://codereview.appspot.com/4917044/diff/1/lily/general-scheme.cc File lily/general-scheme.cc (right):
http://codereview.appspot.com/4917044/diff/1/lily/general-scheme.cc#newcode110 lily/general-scheme.cc:110: if (scm_is_integer (s)) On 2011/08/19 20:20:12, Neil Puttock wrote:
On 2011/08/19 18:04:38, Carl wrote:
> I think the old code here is correct, and the doc-string is wrong.
Both are correct; the only difference is when Guile raises an error.
In
Bertrand's version, it's at the top of the code; in current master,
it's in the
block below when scm_to_int () is called.
OK, I see now. I withdraw my objection to these changes. As an aside, I think that we should change the definition of the property align-dir. It should no longer be called a direction, since it's not limited to the values -1, 0, and 1. But this is a discussion for another thread. Thanks! http://codereview.appspot.com/4917044/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
