overall commment: the parts that do the reporting should not need to
know about the format of loglevel.

I think it would be better to have a

  if (log(ERROR))
  {
    ..
  }

or perhaps even

  log(ERROR, "...")

rather than having each bit do the bitmasking separately like in this
patch.

http://codereview.appspot.com/4822055/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to