----- Original Message -----
From: "Graham Percival" <gra...@percival-music.ca>
To: "Phil Holmes" <m...@philholmes.net>
Cc: <lilypond-devel@gnu.org>
Sent: Wednesday, June 15, 2011 3:35 PM
Subject: Re: Patch: small reduction in output from make doc
On Wed, Jun 15, 2011 at 03:22:14PM +0100, Phil Holmes wrote:
----- Original Message ----- From: "Graham Percival"
<gra...@percival-music.ca>
To: "Phil Holmes" <m...@philholmes.net>
Cc: <lilypond-devel@gnu.org>
Sent: Wednesday, June 15, 2011 2:42 PM
Subject: Re: Patch: small reduction in output from make doc
>Are you sure that it creates *new* log files, instead of
>overwriting the existing .log file? I mean, don't we have a rule
>for .ly -> .log now?
It creates new logfiles, since there is no existing logfile. It
uses the name of the .ly file to generate the logfile name. So -
there is a file called key-initial.ly. Part of the build process
calls lily to process that, and since it has a \midi{} block, a file
called key-initial.midi is produced.
Hmm. Does it only create key-initial.midi, or does it also create
key-initial.pdf ? (or .eps, or .png, etc)
According to the output, it also creates *.pdf. However, none of these
exist in the final build directory. I think the .pdf is incidental - it
looks on my current glance as though the ly->midi->ly process is used to
generate the "MIDI test suite" documentation - although I don't currently
know where that goes...
My concern is that at some point, we might call lilypond again on
key-initial.ly, and then we might redirect that output to .log as
well, and then overwrite the log file since > doesn't check if the
file already exists. IMO, it takes a lot to truly be "too
paranoid" when dealing with build systems.
a) We don't. I've checked. b) We don't create _any_ log files from .ly
files during the build process, except those I've now started to create. c)
Even if we did (N.B. we don't) then no-one looks at the log files and
they're never used, so it wouldn't matter.
Could you change it to .midi.log to make an old man feel safe? ;)
(any age that cannot be represented in 4 bits is "old")
Only if you ask again, having confirmed you've read points a, b and c above.
>$*.log 2>&1
to the end of the call. > redirects output. $*.log expands to
filename.log (in this case key-initial.log - this expansion is a
make feature).
Neat, I didn't know about $*
I'm afraid I've been reading the make manual. It's not pretty.
Cheers,
- Graham
--
Phil Holmes
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
