New patch set uploaded, i think all formatting issues are resolved.
Should i run the regtests again?
http://codereview.appspot.com/4490045/diff/20001/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):
http://codereview.appspot.com/4490045/diff/20001/lily/completion-note-heads-engraver.cc#newcode204
lily/completion-note-heads-engraver.cc:204:
event->set_property("autosplit-end",
On 2011/06/01 21:21:25, Neil Puttock wrote:
set_property (
Done.
http://codereview.appspot.com/4490045/diff/20001/lily/completion-note-heads-engraver.cc#newcode205
lily/completion-note-heads-engraver.cc:205: ly_bool2scm (left_to_do_ -
note_dur.get_length () > Rational (0)));
On 2011/06/01 21:21:25, Neil Puttock wrote:
indent:
event->set_property ("autosplit-end",
ly_bool2scm (
Done.
http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc
File lily/tie-engraver.cc (right):
http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode85
lily/tie-engraver.cc:85: bool has_autosplit_end (Stream_event* event);
On 2011/06/01 21:21:25, Neil Puttock wrote:
Stream_event *event
Done.
http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode125
lily/tie-engraver.cc:125: Tie_engraver::has_autosplit_end (Stream_event*
event)
On 2011/06/01 21:21:25, Neil Puttock wrote:
Stream_event *event
Done.
http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode163
lily/tie-engraver.cc:163: /*
On 2011/06/13 22:51:39, Graham Percival wrote:
On 2011/06/13 22:44:37, karin.hoethker wrote:
> On 2011/06/01 21:21:25, Neil Puttock wrote:
> > indent
>
> I don't see a problem here.
The /* should line up with the "if" on line 159. Line 167 should also
line up
with line 159.
Done.
http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode163
lily/tie-engraver.cc:163: /*
On 2011/06/01 21:21:25, Neil Puttock wrote:
indent
Done.
http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode289
lily/tie-engraver.cc:289: if (left_ev && (tie_event || tie_stream_event)
On 2011/06/01 21:21:25, Neil Puttock wrote:
indent
Done.
http://codereview.appspot.com/4490045/diff/20001/scm/define-music-properties.scm
File scm/define-music-properties.scm (right):
http://codereview.appspot.com/4490045/diff/20001/scm/define-music-properties.scm#newcode44
scm/define-music-properties.scm:44: (autosplit-end ,boolean? "Duration
of event was truncated by automatic splitting in
Completion_heads_engraver.")
On 2011/06/01 21:21:25, Neil Puttock wrote:
the @code{Completion_heads_engraver}.
Done.
http://codereview.appspot.com/4490045/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
