On Mar 30, 2011, at 12:11 AM, Colin Campbell wrote:
> On 11-03-29 08:24 PM, m...@apollinemike.com wrote:
>>
>> On Mar 29, 2011, at 10:12 PM, Colin Campbell wrote:
>>
>>> On 11-03-29 04:54 PM, m...@apollinemike.com wrote:
>>>> On Mar 28, 2011, at 6:39 PM, percival.music...@gmail.com wrote:
>>>>
>>>>> Looks much more readable, thanks!
>>>>>
>>>>>
>>>>> http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc
>>>>> File lily/beam-collision-engraver.cc (right):
>>>>>
>>>>> http://codereview.appspot.com/4290069/diff/11001/lily/beam-collision-engraver.cc#newcode59
>>>>> lily/beam-collision-engraver.cc:59: // Start conisdering grobs at the
>>>>> first grob whose end falls at or after the beam's beginning.
>>>>> typo: conisdering
>>>>>
>>>>> http://codereview.appspot.com/4290069/
>>>> Can somebody please test this patch out on a few thorny keyboard pieces
>>>> before I push it? It will make beam collision kick in on all beams, and I
>>>> want to make sure that I don't run into the same issue I did w/
>>>> accidentals. I would do it myself, but I am not in possession of anything
>>>> that could really test this to the max.
>>>>
>>>> Cheers,
>>>> MS
>>>>
>>>>
>>>
>>> If you point me toward a few thorny keyboard pieces, I can run some tests
>>> for you, Mike.
>>>
>>> Colin
>>
>> Thanks Colin!
>> I don't have any, but I'm assuming that some of these would suffice:
>>
>> http://www.mutopiaproject.org/cgibin/make-table.cgi?searchingfor=debussy
>> http://www.mutopiaproject.org/cgibin/make-table.cgi?searchingfor=scriabin
>> http://www.mutopiaproject.org/cgibin/make-table.cgi?searchingfor=chopin
>>
>> Cheers,
>> MS
> I applied your patchy to a just-now git, ran make and make check cleanly, no
> unexpected regressions, so I used Frescobaldi to force the lilypond version
> to 2.13.57 and compiled the Scriabin Opus 11 nr 1. I didn't see any glaring
> problems, although all those beams broken across staves freaked me only a
> little more than the quintuplets beamed across bar lines!
>
> Hope that helps, Mike.
>
> Colin
Thanks Colin, that helps a great deal.
In that case, I'm giving myself until 15:15 GMT to push the patch. If people
would like a little more time to test it before I push it, please let me know
before then.
Cheers,
MS
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
