[+lilydevel] On Sat, Mar 12, 2011 at 11:17 AM, <hanw...@gmail.com> wrote: > > http://codereview.appspot.com/4286042/diff/2001/lily/balloon.cc > File lily/balloon.cc (right): > > http://codereview.appspot.com/4286042/diff/2001/lily/balloon.cc#newcode77 > lily/balloon.cc:77: return SCM_EOL; > not sure I follow. Why not > > if (!me->spanned_rank().contains(pos)) return > > ? > > also, you couldl just look at me->break_index_ to see if you're on the > right piece? > > wanted = (d ==LEFT) ? parent->broken_.begin() : parent->broken_.end()-1; > if (me!=wanted) return > > http://codereview.appspot.com/4286042/diff/2001/lily/system.cc > File lily/system.cc (right): > > http://codereview.appspot.com/4286042/diff/2001/lily/system.cc#newcode272 > lily/system.cc:272: if (pos < (int)start) > new style casts. > > http://codereview.appspot.com/4286042/ >
-- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
