2011/3/1 Trevor Daniels <t.dani...@treda.co.uk> > > Janek Warchoł wrote Monday, February 28, 2011 1:02 PM > >> 2011/2/28 Trevor Daniels <t.dani...@treda.co.uk> >> >>> This commit causes many changes to the reg tests due to the small >>> increase in some of the stems that protrude beyond the staff. >>> Virtually all of the changes look good, but one struck me as undesirable. >>> >>> It is in cue-clef-begin-of-score.ly. Here the stems on the d full-size >>> notes seem undesirably lengthened. Is the clef change being >>> ignored here? >> >> I don't have access to my main machine so i cannot see new output for myself, >> but i can say that in this regtest all four notes should have longer stems >> now. >> In general, stems of the notes that are on the middle line will be >> longer now and it is desired behaviour. > > Yes, they are longer, but the stems on the full-size notes look too long > in this context to my eye. > > I've attached the output from 2.13.52.
In my opinion it is ok. While i agree that in this particular example the stems may look *slightly* better if they were a bit shorter, i suppose that implementing this (i.e. making stem length depend on a broader context than their position on the staff) would require too much work; i also don't see by what criteria this could be judged. Since vast majority of cases look better with this patch, and this problem isn't serious imo, i suggest leaving it alone. cheers, Janek PS my first patch is now in an official LilyPond release! Hooray! _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
