On a second pass I found one version number I had missed, and one mistake.
Posted and mailed to Graham. On 2011/02/05 18:10:25, Neil Puttock wrote:
LGTM.
http://codereview.appspot.com/4001057/diff/1/Documentation/snippets/engravers-one-by-one.ly#newcode4
Documentation/snippets/engravers-one-by-one.ly:4: \version "2.13.46" This shouldn't be converted: running makelsr.py will change it back to
2.12.2
(since there are no changes in the file between 2.12.2 and master).
I think the appropriate solution is to copy the file into snippets/new, but need to check with the build-meister. http://codereview.appspot.com/4001057/diff/7002/Documentation/web/ly-examples/sesto-full.ly File Documentation/web/ly-examples/sesto-full.ly (right): http://codereview.appspot.com/4001057/diff/7002/Documentation/web/ly-examples/sesto-full.ly#newcode54 Documentation/web/ly-examples/sesto-full.ly:54: \description "Like StaffGroup, but without spanbar" Restore these user-defined contexts; I thought they were identical to ChoirStaff but they are not. http://codereview.appspot.com/4001057/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
