On 1/23/11 4:03 AM, "Trevor Daniels" <t.dani...@treda.co.uk> wrote:
> The code below seems to satisfy a request > seen several times on -user. Assuming the code > is good I'd prefer to see this added to the LP > distribution rather than the LSR. > > What do you think? Looks reasonable to me. The code needs to be put in a .scm file (scm/modal-transpose.scm), and the music function needs to go to ly/music-functions-init.ly. The publically-accessible functions need to be define-public. The indentation isn't right. I think the errors should be turned into warnings. If the transposer pitches aren't valid, the transposer should just return the argument to be transposed without transposition. We shouldn't abort when we have the chance to continue gracefully but with a warning. make-extended-scale has a display-scheme-music call that I think should be eliminated. We need a shortened version of the demo for a regression test. And we need a doc-section written. But the code generally looks good to me. I think we should get it added. Thanks, Carl _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
