I have now uploaded a final patch for cue notes with custom clef, which I think is in a state so that it can be included in lilypond master:
http://codereview.appspot.com/2726043/ Any further objectsions/suggestions? Or can I push to master? I have included almost all comments so far, except for: -) code duplication with the Clef_engraver, which is not easily solved, since we need to call also member functions of the engraver and access lots of different properties. The only way to share code would be to use a function with ~7 arguments, one of which is a pointer to the engraver, two would be refernces to the engraver's clef_ and octavate_ members, which the function would set. I don't think this is really good coding practice, so I didn't change that. If did resolve the OctavateEight code duplication in Cue_clef_engraver, though. -) code duplication in scm/parser-clef.scm, which also needs to set several properties with different names for standard clefs and for cue clefs. Cheers, Reinhold -- ------------------------------------------------------------------ Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial & Actuarial Math., Vienna Univ. of Technology, Austria * http://www.fam.tuwien.ac.at/, DVR: 0005886 * LilyPond, Music typesetting, http://www.lilypond.org _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
