The patch looks bigger than it is, due to my moving a block. I explain in reply-comments below how I am incorporating the suggestions.
You deduced correctly that I sinned in labeling something a PATCH that didn't first get a build test. (I dual-boot and only connect through windows, causing some impatience that leads to makes.) Minor delay while I straighten that out before another mistake. http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely#newcode313 Documentation/notation/expressive.itely:313: \bar "||" e2\p\< f | e2\> d\! | a2\< b | c1\decr s1*0\! \bar "|." On 2010/12/20 18:53:19, Graham Percival wrote:
That said, we have sometimes used \break
I have difficulty keeping my place in the input when it gets this long vertically, in contrast to Carl. Probably too much detail here for one @lilypond to convey to the variety of human readers. I'll revert this example, and convert my long line to a style-compliant separate @lilypond, introduced by "The horizontal extent of a hairpin reflects the musical moments on which it begins and ends." The purpose of this example is to demonstrate the information that James pulled in from the hairpin-length reg-test, and the two-dynamics syntax c4\p\<, without making the section too long. http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely#newcode324 Documentation/notation/expressive.itely:324: \bar "||" I'll put this in standard style http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely#newcode341 Documentation/notation/expressive.itely:341: The commands @code{\crescTextCresc}, @code{\dimTextDecresc}, On 2010/12/20 18:53:19, Graham Percival wrote:
Delete this whole paragraph, and replace with
Amen, brother! This was a moved block, and I was timid in my editing. http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely#newcode352 Documentation/notation/expressive.itely:352: \dimHairpin c2\< d\! | e\> d\! \bar "||" On 2010/12/20 10:57:44, Trevor Daniels wrote:
drop \bar's [...] full set of \dimTexts
Okay. Starting again from the old example, Graham's suggestion to use crotchets gives enough room for all the texts. http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely#newcode390 Documentation/notation/expressive.itely:390: in @rlearning{Moving-objects}. On 2010/12/20 12:54:37, Trevor Daniels wrote:
Broken ref
Working on it. Also fixing "can by" -> "can be" http://codereview.appspot.com/3732046/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): http://codereview.appspot.com/3732046/diff/1/Documentation/notation/text.itely#newcode170 Documentation/notation/text.itely:170: Text spanners are part of the @code{Dynamics} context; see I should have deleted this sentence, as the Dynamic context is now mentioned in the section on dynamics, and text spanners can live in several contexts. http://codereview.appspot.com/3732046/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
