http://codereview.appspot.com/2723043/diff/109001/lily/tab-harmonic-engraver.cc File lily/tab-harmonic-engraver.cc (left):
http://codereview.appspot.com/2723043/diff/109001/lily/tab-harmonic-engraver.cc#oldcode83 lily/tab-harmonic-engraver.cc:83: "HarmonicParenthesesItem ", This is never created, even for \tabFullNotation. http://codereview.appspot.com/2723043/diff/109001/lily/tab-harmonic-engraver.cc File lily/tab-harmonic-engraver.cc (right): http://codereview.appspot.com/2723043/diff/109001/lily/tab-harmonic-engraver.cc#newcode59 lily/tab-harmonic-engraver.cc:59: victim->set_property ("style", ly_symbol2scm ("harmonic")); This makes it difficult for users to tweak the appearance of the harmonic brackets, though if you still think it's a price worth paying, you might as well junk the engraver and read 'articulations directly inside the notehead callback. http://codereview.appspot.com/2723043/diff/109001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/2723043/diff/109001/scm/define-grob-properties.scm#newcode965 scm/define-grob-properties.scm:965: (display-cautionary ,boolean? "Display as cautionary.") Needs a more descriptive docstring. http://codereview.appspot.com/2723043/diff/109001/scm/tablature.scm File scm/tablature.scm (right): http://codereview.appspot.com/2723043/diff/109001/scm/tablature.scm#newcode297 scm/tablature.scm:297: (whiteout (ly:grob-property grob 'whiteout #t)) If 'whiteout is set, it's applied to the final stencil in grob.cc. http://codereview.appspot.com/2723043/diff/109001/scm/tablature.scm#newcode321 scm/tablature.scm:321: (centered-stencil output-grob))) This has a nasty side-effect: it centres the noteheads on the PaperColumn, shifting them to the left of heads in other staves. http://codereview.appspot.com/2723043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
